fix: persist and restore active task on VS Code restart #7660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add currentActiveTaskId to global settings schema - Persist task ID when adding/removing tasks from stack - Restore last active task in resolveWebviewView on startup - Add comprehensive tests for task persistence functionality Fixes #7659
dosubot
bot
added
size:L
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| } else { | ||
| // Update to the new top task | ||
| const newCurrentTask = this.clineStack[this.clineStack.length - 1] | ||
| await this.updateGlobalState("currentActiveTaskId", newCurrentTask.taskId) |
Contributor
Author
There was a problem hiding this comment.
Is this intentional? There's a potential race condition here between checking the stack length and updating the task ID. If another operation modifies the stack between lines 425 and 430, we might update to the wrong task ID. Consider using a lock or making this operation atomic.
| await this.removeClineFromStack() | ||
|
|
||
| // Attempt to restore the last active task if one was persisted | ||
| const lastActiveTaskId = this.getGlobalState("currentActiveTaskId") |
Contributor
Author
There was a problem hiding this comment.
The task restoration logic could benefit from explicit cleanup if restoration fails partway through. Consider wrapping this in a try-finally block to ensure any partially initialized resources are properly released on error:
Suggested change
| const lastActiveTaskId = this.getGlobalState("currentActiveTaskId") | |
| const lastActiveTaskId = this.getGlobalState("currentActiveTaskId") | |
| if (lastActiveTaskId && typeof lastActiveTaskId === "string") { | |
| let partiallyRestoredTask = null | |
| try { | |
| const { historyItem } = await this.getTaskWithId(lastActiveTaskId) | |
| if (historyItem) { | |
| partiallyRestoredTask = await this.createTaskWithHistoryItem(historyItem) | |
| this.log(`Restored last active task: ${lastActiveTaskId}`) | |
| } | |
| } catch (error) { | |
| // Task may have been deleted or corrupted, clear the saved ID | |
| this.log(`Failed to restore last active task ${lastActiveTaskId}: ${error}`) | |
| await this.updateGlobalState("currentActiveTaskId", undefined) | |
| } finally { | |
| // Clean up any partially restored task if needed | |
| if (partiallyRestoredTask && this.clineStack.length === 0) { | |
| // Cleanup logic here if needed | |
| } | |
| } | |
| } |
| lastShownAnnouncementId: z.string().optional(), | ||
| customInstructions: z.string().optional(), | ||
| taskHistory: z.array(historyItemSchema).optional(), | ||
| currentActiveTaskId: z.string().optional(), |
Contributor
Author
There was a problem hiding this comment.
Could we add a more descriptive JSDoc comment here? Something like:
Suggested change
| currentActiveTaskId: z.string().optional(), | |
| /** | |
| * The ID of the currently active task that should be restored when VS Code restarts. | |
| * This ensures chat context persistence across unexpected crashes or restarts. | |
| * @since 3.26.7 | |
| */ | |
| currentActiveTaskId: z.string().optional(), |
| } | ||
| } catch (error) { | ||
| // Task may have been deleted or corrupted, clear the saved ID | ||
| this.log(`Failed to restore last active task ${lastActiveTaskId}: ${error}`) |
Contributor
Author
There was a problem hiding this comment.
Consider adding more detailed logging here for debugging purposes. Including task details in the error log would help diagnose restoration issues:
Suggested change
| this.log(`Failed to restore last active task ${lastActiveTaskId}: ${error}`) | |
| // Task may have been deleted or corrupted, clear the saved ID | |
| this.log(`Failed to restore last active task ${lastActiveTaskId}: ${error instanceof Error ? error.message : String(error)}`) | |
| this.log(`Task restoration error details: ${JSON.stringify({ taskId: lastActiveTaskId, error: error instanceof Error ? { message: error.message, stack: error.stack } : error })}`) | |
| await this.updateGlobalState("currentActiveTaskId", undefined) |
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Closing, see #7659 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #7659 where Roo Code loses chat context when VS Code unexpectedly crashes or needs to be restarted. The last active chat now persists and automatically restores when VS Code restarts.
Problem
Solution
currentActiveTaskIdfield to global settings schema to track the active taskChanges
currentActiveTaskIdfield to schemaaddClineToStack()andremoveClineFromStack()resolveWebviewView()Testing
Related Issues
Fixes #7659
Checklist
Important
This PR fixes task context loss on VS Code restart by persisting and restoring the active task ID, with changes in
global-settings.tsandClineProvider.ts, and adds comprehensive tests.currentActiveTaskIdtoglobalSettingsSchemainglobal-settings.tsto track active task.addClineToStack()andremoveClineFromStack()inClineProvider.ts.resolveWebviewView()inClineProvider.ts.ClineProvider.spec.tsfor task persistence and restoration.This description was created by
for e9fa2a6. You can customize this summary. It will automatically update as commits are pushed.